IntersectMBO/plutus

The evaluate-builtins optimization isn't conservative

Open

#6,167 建立於 2024年6月3日

在 GitHub 查看
 (1 留言) (1 反應) (0 負責人)Haskell (1,637 star) (511 fork)batch import
Good first issueInternalPlutus IRbugoptimizationstatus: triagedtech debt

描述

PlutusIR.Transform.EvaluateBuiltins turns ifThenElse True x y into x. That is not conservative: if y throws then the former term will throw and the latter one won't. So this is a bug that needs to be fixed. It wasn't discussed in the original PR.

More importantly, this looks like something that the proper property testing should catch. Look like a perfect opportunity for the PIR generators to show their power. So it'd be best to first write a failing property, then fix the bug.

貢獻者指南

技術棧
無
領域
backendtesting
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Plutus IR basicsProperty testingHaskell
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Examine the transformation in PlutusIR.Transform.EvaluateBuiltins that reduces ifThenElse with a constant boolean. Understand the original PR #5269 for context. Then design a property test using the PIR generators that checks that the transformation preserves semantics even when branches may throw. After a failing test is produced, fix the transformation to be conservative.