HeroTransitions/Hero

Hero makes my CAEmitterLayer work inconsistently

開放

#716 建立於 2021年3月17日

 (5 則留言) (2 個反應) (1 位負責人)Swift (1,735 個分叉)batch import
confirmed buggood first issueneed help

倉庫指標

星標
 (22,453 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

What did you do?

Hi, many thanks to all the people maintaining the library and providing support ❤️. I use a CAEmitterLayer to make some confettis pop as soon a view is displayed. When Hero is used to transition (with an animation) to the view controller containing the CAEmitterLayer, Confettis will be emitted (that's ok) but when you repeat the process (dismiss the controller then show it again) : Confettis will never be emitted again! TL:DR : As soon as Hero is used to do something in the app, my CAEmitterLayer will work inconsistently.

What did you expect to happen?

The CAEmitterLayer emitting confettis every time the view controller is displayed.

What happened instead?

The CAEmitterLayer will emit confettis the first time the controller is displayed, sometimes the second time and never again!

General Information

  • Hero Version: 1.6.1

  • iOS Version(s): 14.4

  • Swift Version: 5.3

  • Devices/Simulators: All

  • Reproducible in Examples? (Yes/No): Yes

Demo Project

Note : If you deactivate the hero navigationAnimationType in the ViewController, everything will work as expected.

caemitterlayerbug.zip

貢獻者指南