Hammerspoon/hammerspoon

windowHints hotkey modal clashes with user defined modals

Open

#606 建立於 2015年10月14日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Objective-C (15,415 star) (688 fork)batch import
bughelp wanted

描述

It seems like windowHints implementation is based on modal hotkeys, and it defines a global variable named "k" for the modal. That global variable was clashing with my own modal variable (also named "k") causing weird behavior. Changing my modal variable name fixed it.

I'm not experienced enough with hammerspoon or lua to fix this myself. Is it possible to use a local variable in the windowHints module? Maybe the windowHints variable should have a less common name?

I believe this is the line causing trouble.

Thanks!

貢獻者指南

技術棧
無
領域
desktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Lua basicsHammerspoon setup
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
Examine the windowHints module at extensions/hints/init.lua. The global variable 'k' on line 175 should be changed to a local variable or renamed to avoid clashes with user defined modals. Check if there are other global variables in the same module that could cause similar issues. Also verify that the change does not break any other functionality that depends on the global 'k'.