HabitRPG/habitica

Refactor Justin intro modal to separate it from avatar edit

Open

#10,803 建立於 2018年11月2日

在 GitHub 查看
 (6 留言) (0 反應) (0 負責人)JavaScript (10,775 star) (3,912 fork)batch import
help wantedpriority: minorsection: Avatar/User Modal

描述

Description

creatorIntro.vue is used both for initial avatar setup on account creation, and for editing a user's avatar via the user menu. This makes it difficult to consistently position both modals, because ideal positioning for the Justin sequence pushes the much larger avatar edit modal partially offscreen.

What we should do is pull the shared avatar-related pieces out to a component that's then plugged into two separate modals, Justin and post-setup avatar editing. Then, reposition the Justin sequence so it's centered better onscreen.

貢獻者指南

技術棧
vuejavascript
領域
frontend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Vue.jsunderstanding of component refactoringknowledge of modal UI patterns
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Examine the current `creatorIntro.vue` component to understand how it handles both the Justin intro and avatar editing. Identify the shared avatar related pieces (likely the avatar preview and controls) that can be extracted into a separate component. Then, create two new modals: one for the Justin sequence and one for post setup avatar editing, each using the shared component. Ensure the Justin sequence modal is repositioned to be centered on screen.