Graylog2/graylog2-server

Don't sort output config fields by optionality

Open

#4,761 建立於 2018年4月25日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Java (6,945 star) (1,032 fork)batch import
good first issuepapercuttriaged

描述

Expected Behavior

The config fields of my output plugin appear in the order I registered them.

Current Behavior

If some of them are optional, they are shown below all others.

Possible Solution

Don't sort the fields by optionality.

Steps to Reproduce (for bugs)

Register two output config fields and make the first optional.

Context

https://github.com/Graylog2/graylog2-server/pull/4746#issuecomment-384253076

Your Environment

(not relevant)

貢獻者指南

技術棧
javajavascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
familiarity with React componentsunderstanding of Graylog configuration forms
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
The issue is in the ConfigurationForm.jsx component, specifically at line 156 where fields are sorted by optionality. The fix is to remove or modify this sorting to preserve the original registration order. Refer to linked PR #4746 and comment for context. No additional changes to other parts of the codebase are required.