GraphiteEditor/Graphite

Dragging layers sharing a transform node applies multiple translations

Open

#1,529 建立於 2023年12月20日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Rust (1,176 fork)batch import
Good First Issue

倉庫指標

Star
 (25,662 star)
PR 合併指標
 (平均合併 6天 9小時) (30 天內合併 65 個 PR)

描述

Still a problem as of Jan 30, 2025. This happens with dragging but not G of the G/R/S feature, which is a good hint about how to begin solving it in the same manner.


Create a document containing two rectangles. Enter the node graph and add a layer node, using the data from the stroke node of one of the rectangles. Select all of the rectangles and drag them using the select tool. Observe how the translation is applied several times. When you drag around several layers we apply a transformation to the first transform node found for each layer; however because there are several layers sharing the same transform node, the translation is applied several times.

This also applies when dragging the top/left corners of an artboard with the Artboard tool (as was implemented in #2150).

Solutions:

  • In select_tool.rs, instead of applying a delta to the current transform, store the transform at the start of the drag and compute the new transform based on that (similar to how dragging the selection bounds works)
  • In graph_operation_message_handler.rs, check for cases where the node is used by several other nodes, and if that is the case then create a new transform node for each layer separately before applying the operation.

https://github.com/GraphiteEditor/Graphite/assets/78500760/8011ef59-a055-4e29-87a8-9df5d73351e6

貢獻者指南