GoogleContainerTools/skaffold

Refactor code and remove duplication

開放

#7,318 建立於 2022年4月15日

 (0 則留言) (0 個反應) (0 位負責人)Go (1,416 個分叉)batch import
help wantedkind/starter-projectkind/todopriority/p3

倉庫指標

星標
 (12,822 顆星)
PR 合併指標
 (平均合併 3天 6小時) (30 天內合併 16 個 PR)

描述

This task is about remove code duplication.

The skaffold filter command was added to apply debug transformations to configure container images for debugging. See here -> https://skaffold.dev/docs/workflows/debug/#configuring-container-images-for-debugging

When skaffold filter command was added it did not need any information from the run context.

However, after @aaron-prindle added the Resource Selector config where users can configure which resource types to transform. These list now needs to be passed to Filter command. In #7317, @tejal29 duplicated the functionality in getTransformList

The right way to do this is, Add Filter() method to the SkaffoldRunner which has access to the runner.RunContext.TransformAllowList and runCtx.runner.RunContext.TransformDenyList

The new Filter method will additionally execute the runFilter in here

貢獻者指南