GoogleContainerTools/skaffold

Refactor code and remove duplication

Open

#7,318 建立於 2022年4月15日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Go (12,822 star) (1,416 fork)batch import
help wantedkind/starter-projectkind/todopriority/p3

描述

This task is about remove code duplication.

The skaffold filter command was added to apply debug transformations to configure container images for debugging. See here -> https://skaffold.dev/docs/workflows/debug/#configuring-container-images-for-debugging

When skaffold filter command was added it did not need any information from the run context.

However, after @aaron-prindle added the Resource Selector config where users can configure which resource types to transform. These list now needs to be passed to Filter command. In #7317, @tejal29 duplicated the functionality in getTransformList

The right way to do this is, Add Filter() method to the SkaffoldRunner which has access to the runner.RunContext.TransformAllowList and runCtx.runner.RunContext.TransformDenyList

The new Filter method will additionally execute the runFilter in here

貢獻者指南

技術棧
go
領域
clidevopsinfrastructure
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go programmingskaffold codebase
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
The implementation requires adding a Filter() method to the SkaffoldRunner that uses TransformAllowList and TransformDenyList from runner.RunContext (see pkg/skaffold/runner/runcontext/context.go lines 111+). This method should execute the runFilter logic currently in cmd/skaffold/app/cmd/filter.go line 59. The duplicated getTransformList function in the filter command should be removed and replaced by calling the new Filter method. The existing test suite for filter should be updated to cover the new implementation.