GoogleContainerTools/skaffold

Configuration dependencies don't resolve paths to deploy hooks

Open

#7,250 建立於 2022年3月31日

在 GitHub 查看
 (10 留言) (0 反應) (0 負責人)Go (12,822 star) (1,416 fork)batch import
area/hookshelp wantedkind/bugpriority/p3

描述

Expected behavior

When having a toplevel configution like this:

apiVersion: skaffold/v2beta25
kind: Config
requires:
  - configs: ["cfg1"]
    path: cfg1/skaffold.yaml
  - configs: ["cfg2"]
    path: cfg2/skaffold.yaml

When the skaffold.yaml files in ./cfg1 and ./cfg2 define deploy hooks, the paths to these hooks should resolved relative to the ./cfg1, or ./cfg2 directory. For instance if ./cfg2 has:

deploy:
  kubectl:
    manifests:
    - deploy/kubernetes.yaml
    hooks:
      before:
        - host:
            command: ["sh", "-c", "deploy/skaffold-before-hook.sh"]

it should look for skaffold-before-hook.sh in ./cfg2/deploy/ and not in ./deploy. Also, any files that are created or referenced by this hook should be relative to ./cfg2

Actual behavior

hooks are resolved relative to the toplevel directory. I have to make a symlink ./deploy/skaffold-before-hook.sh --> ../cfg2/deploy/skaffold-before-hook.sh

Information

  • Skaffold version: 1.37.0
  • Operating system: Linux Ubuntu 20.04
  • Installed via: skaffold.dev

貢獻者指南

技術棧
go
領域
clideveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go programming languageSkaffold tool basicsYAML configuration
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Investigate how Skaffold resolves paths for deploy hooks in dependent configs. Look at the code that processes the 'requires' field and the hook execution in the 'deploy' package. The fix likely involves ensuring that relative paths in hooks are resolved relative to the config file's directory. Check the configuration parsing logic in the 'pkg/skaffold/config' package and the deploy hook execution in 'pkg/skaffold/deploy'.