area/deploydeploy/helmhelp wantedkind/feature-requestpriority/p2
倉庫指標
- 星標
- (12,822 顆星)
- PR 合併指標
- (平均合併 3天 6小時) (30 天內合併 16 個 PR)
描述
On Skaffold v1.35.0, when a Helm 2 deploy is used, as soon as the dependency's requirements.lock file is added or changes, a rebuild is launched. Seems like #4181 was aimed at fixing this but somehow this only prevents the rebuild for the tmpcharts folder and its content, not the requirements.lock file.
Expected behavior
No rebuild on requirements.lock change
Actual behavior
Rebuild on requirements.lock change
Information
- Skaffold version: v1.35.0
- Operating system: Linux, on a local KIND cluster
- Installed via: https://storage.googleapis.com/skaffold/releases/latest/skaffold-linux-amd64
- Contents of skaffold.yaml:
deploy:
helm:
releases:
- name: project
chartPath: helm
artifactOverrides:
backendImage: backend-image
frontendImage: frontend-image
databaseImage: database-image
valuesFiles:
- helm/values.yaml
- helm/values.yaml.override
flags:
upgrade:
- '--cleanup-on-fail'
Steps to reproduce the behavior
Use a Helm 2 chart having a dependency, on first install the project builds twice because of the creation of the requirements.lock file