GoogleContainerTools/skaffold

Moved debug log to Warning with more information on what users can do to get rid of it.

開放

#5,466 建立於 2021年2月26日

 (0 則留言) (0 個反應) (0 位負責人)Go (1,416 個分叉)batch import
area/loggingbugbash/q4-2022help wantedkind/usabilitypriority/p3

倉庫指標

星標
 (12,822 顆星)
PR 合併指標
 (平均合併 3天 6小時) (30 天內合併 16 個 PR)

描述

While debugging #5159, i saw the following log lines in debug mode

Tags used in deployment:
 - skaffold-example -> skaffold-example:a4ac60aa40be5710a98b1bc7b7de1471e7dee35cd3ba76b87ae1eb95bfca2820
DEBU[0013] push value not present, defaulting to false because cluster.PushImages is false 
DEBU[0013] Local images can't be referenced by digest.
They are tagged and referenced by a unique, local only, tag instead.
See https://skaffold.dev/docs/pipeline-stages/taggers/#how-tagging-works 

DEBU[0013] getting client config for kubeContext: `kind-kind` 
Loading images into kind cluster nodes...
 - skaffold-example:a4ac60aa40be5710a98b1bc7b7de1471e7dee35cd3ba76b87ae1eb95bfca2820 -> DEBU[0013] Running command: [kubectl --context kind-kind get nodes -ojsonpath='{@.items[*].status.images[*].names[*]}'] 
DEBU[0013] Command output: ['....'] 
DEBU[0013] Running command: [kind load docker-image --name kind skaffold-example:a4ac60aa40be5710a98b1bc7b7de1471e7dee35cd3ba76b87ae1eb95bfca2820] 
DEBU[0015] Command output: [], stderr: Image: "skaffold-example:a4ac60aa40be5710a98b1bc7b7de1471e7dee35cd3ba76b87ae1eb95bfca2820" with ID "sha256:a4ac60aa40be5710a98b1bc7b7de1471e7dee35cd3ba76b87ae1eb95bfca2820" not yet present on node "kind-control-plane", loading... 
Loaded
Images loaded in 1.704 second
Starting deploy...

The below log line sounds like a warning i need to pay attention to. https://skaffold.dev/docs/pipeline-stages/taggers/#how-tagging-works explains the warning to me but no information on what to do to remove this warning.

DEBU[0013] Local images can't be referenced by digest.
They are tagged and referenced by a unique, local only, tag instead.
See https://skaffold.dev/docs/pipeline-stages/taggers/#how-tagging-works 

I propose, we either

  1. remove this debug information and say something more explicit
DEBU[0013] generating/using  tag  for skaffold-example:a4ac60aa40be5710a98b1bc7b7de1471e7dee35cd3ba76b87ae1eb95bfca2820 for because local images can't be referenced by digest.
  1. or remove completely

貢獻者指南