GoogleContainerTools/skaffold

Use enum instead of string for "InProgress" , "Succeeded", "Started", "Failed"

Open

#2,967 建立於 2019年10月1日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Go (12,822 star) (1,416 fork)batch import
area/eventingbugbash/q4-2022help wantedkind/todopriority/p3

描述

Expected behavior

Currently we have "Build Complete", "Deploy Complete" as status messages when a build or deploy successfully complete.

While "Deploy Failed" and "Build Failed" when build or deploy failed.

After discussion with IDE teams, they mentioned we could change it to "Succeeded" instead of "Complete" to be in sync with "Failed".

貢獻者指南

技術棧
go
領域
clibackenddevops
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go programmingFamiliarity with skaffold build/deploy workflows
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Search for string literals like "Build Complete", "Deploy Complete", "Build Failed", "Deploy Failed" in the codebase, likely in files under pkg/skaffold/build/ and pkg/skaffold/deploy/. Also check for existing enum patterns in the project. Define a new enum type (e.g., Status) with iota values for InProgress, Succeeded, Started, Failed, and replace all occurrences. Ensure consistency with any existing status enums.