GoogleChromeLabs/quicklink
在 GitHub 查看An additional `div` markup is wrapped around each router component by `withQuicklink` HOC
Open
#193 建立於 2020年7月2日
help wanted
倉庫指標
- Star
- (10,861 star)
- PR 合併指標
- (平均合併 47天 12小時) (30 天內合併 4 個 PR)
描述
Describe the bug
As you can see in the HOC, we have an additional div markup wrapping around the Component (probably it would be a route component) so inserting that div markup could break the app styling since the app styling does not expect another div to be inserted by withQuicklink HOC.
To Reproduce
If we use nest CSS selector without considering that div, we might break the styling.
Expected behavior I hope we could avoid adding any wrapping markup around a route component if possible. At least, I hope we manage to avoid impacting the rest of the app as well as the styling in any case.
Version:
- Quicklink 2.0
cc @addyosmani @demianrenzulli