GoogleChromeLabs/quicklink

Do not prefetch links with `download` attribute

Open

#181 建立於 2020年5月15日

在 GitHub 查看
 (1 留言) (1 反應) (0 負責人)JavaScript (10,861 star) (431 fork)batch import
enhancementgood first issue

描述

Is your feature request related to a problem? Please describe. Currently all links are prefetched including ones intended for downloadable assets. Since these links could point to large payloads (imagine multi megabyte PDFs or zip archives) that's quite a waste of bandwidth.

I'd argue excluding links which have the download attribute would be a sensible default.

Describe the solution you'd like

document.querySelectorAll('a:not([download])')

Thank you :)

貢獻者指南

技術棧
javascripthtml
領域
frontendperformance
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic JavaScriptDOM querySelectorsQuicklink library structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
Locate the code in quicklink's source where links are selected for prefetching, likely in the main prefetch function. Modify the query selector to exclude links with the `download` attribute. Ensure that the change is applied consistently across any link collection logic. No additional changes required beyond the selector update.