GoogleChromeLabs/quicklink

Consider adding `rootMargin` to the Intersection Observer

Open

#14 建立於 2018年12月10日

在 GitHub 查看
 (13 留言) (1 反應) (0 負責人)JavaScript (10,861 star) (431 fork)batch import
enhancementgood first issuehelp wanted

描述

Feedback from @surma:

I feel like by default you should add a rootMargin to the IO to trigger the load before something comes into the viewport.

So, rootMargin defaults to "0px 0px 0px 0px", meaning the intersection will be computed between the root element's unmodified bounds rectangle and the target's bounds. This change would be made to https://github.com/GoogleChromeLabs/quicklink/blob/master/src/index.mjs#L21

貢獻者指南

技術棧
javascript
領域
frontendperformance
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Intersection Observer APIJavaScriptquicklink library structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Review the conversation in the comments to understand desired behavior. The change needs to be made in src/index.mjs around line 21 where the Intersection Observer is instantiated. Ensure the rootMargin option is exposed and defaults to '0px 0px 0px 0px' if not provided. Test that prefetching triggers earlier with a non zero rootMargin.
Consider adding `rootMargin` to the Intersection Observer · GoogleChromeLabs/quicklink#14 | Good First Issue