GoogleChrome/lighthouse-ci

Report GitHub check status differently when highest failing assert is a warning

Open

#375 建立於 2020年7月8日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)JavaScript (5,965 star) (658 fork)batch import
P3enhancementgood first issue

描述

I've currently set a assert profile like this:

module.exports = {
  ci: {
    ...
    assert: {
      ...
      assertions: {
        "categories:performance": "warn",
        "categories:best-practices": "warn",
        "categories:seo": "warn",
        "uses-long-cache-ttl": "off",
        "uses-http2": "off"
      }
    }
  }
}

What I get on github is this:

The message is fine, but having a success conclusion makes the checks panel to auto-collapse, so users won't be attracted to it at all. Maybe we should use neutral or find another way to improve that, but without failing the check?

貢獻者指南

技術棧
javascriptnodejs
領域
ci cddevopstooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Node.jsGitHub Checks API basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The issue requests changing the GitHub check conclusion from 'success' to 'neutral' when all failing asserts are warnings. Investigate the assertion logic in the lighthouse ci codebase, likely in the 'assert' module. Look at how the check run is created and where the conclusion is set. Consider using the GitHub Checks API to update the conclusion to 'neutral' while keeping the overall check as passing. Refer to the existing implementation and the GitHub API documentation for check runs.