Galooshi/import-js

ImportJS misidentifies `import` methods to be Dynamic Import

Open

#529 建立於 2019年3月18日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)JavaScript (519 star) (70 fork)batch import
bughelp wanted

描述

I just run ImportJS on a huge codebase and the results are mostly good, but this one seemed peculiar enough for me to report it:

I'm not too familiar with the lib, but in this case it broke the code by sorting two variable assignments in false order.

Used ImportJS 3.2.0 on Mac OS, via CLI:

find ./client -name "**.js*" -exec importjs fix --overwrite {} \;

//.importjs.js
module.exports = {
    declarationKeyword: 'import',
    environments: ['meteor', 'node'],
    excludes: ['.meteor/local/**', '.vscode/**'],
    mergableOptions: {
        globals: false,
    },
    useRelativePaths: true
}

貢獻者指南

技術棧
javascript
領域
toolingdeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Basic knowledge of JavaScript module systemUnderstanding of static vs dynamic imports
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
The issue reports that ImportJS incorrectly identifies certain import methods as dynamic imports, causing incorrect sorting of variable assignments. Investigate the parsing logic in the source code, likely in the `import js` package's detection of import statements. Look at how the library distinguishes between static and dynamic imports, and check for any edge cases in regex or AST parsing. The screenshot shows an example where two import like lines are sorted wrongly. Focus on the function that handles import identification and sorting, and try to reproduce the issue with the provided configuration.