FuelLabs/sway

DCA improvements

Open

#6,007 建立於 2024年5月14日

在 GitHub 查看
 (2 留言) (0 反應) (1 負責人)Rust (61,702 star) (5,421 fork)batch import
DCAgood first issue

描述

I think there is room for improvement on our DCA. For example, the screenshot below shows how rustc considers: A, T and f to be dead, because no "live code" actually uses them.

image

We, on the other hand, consider the mere presence of impls enough for them to not be dead.

image

Remove the impl and we now correctly mark this as dead. But the error message is not as clear as rustc's, which says the struct is never "constructed".

image image

This is all done at sway-core/src/control_flow_analysis/dead_code_analysis.rs and seems a candidate for "good first issue".

貢獻者指南

技術棧
rust
領域
toolingdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
RustSway compiler basicsdead code analysis concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Start by examining the dead code analysis logic in sway core/src/control flow analysis/dead code analysis.rs. Compare its behavior with rustc's DCA, particularly how rustc marks items as dead based on usage. Then modify the logic to detect and report dead items with clearer error messages similar to rustc's 'never constructed' phrasing.