FuelLabs/fuel-core

Separate Execution Gas Price and DA Gas Price into separate newtypes to add clarity

Open

#2,382 建立於 2024年10月22日

在 GitHub 查看
 (2 留言) (0 反應) (1 負責人)Rust (57,084 star) (2,861 fork)batch import
good first issue

描述

It's been suggested that we separate the two just to help organize the code a bit better. Instead of just dealing withu64 everywhere, it could help the reader to have types to communicate everywhere in the code the purpose of the numbers.

貢獻者指南

技術棧
rust
領域
backendblockchain
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic Rust knowledgeUnderstanding of gas pricing in FuelFamiliarity with newtype pattern
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Review the discussion in PR #2364, specifically the comment that suggested separating the types. Then identify all occurrences of `u64` representing gas prices in the codebase, distinguishing between execution gas price and DA gas price. Create two newtypes, e.g., `ExecutionGasPrice` and `DaGasPrice`, implementing necessary traits (e.g., arithmetic, serialization), and refactor all usages to use them. Consult the linked PR for additional context and potential pitfalls.
Separate Execution Gas Price and DA Gas Price into separate newtypes to add clarity · FuelLabs/fuel-core#2382 | Good First Issue