FormidableLabs/rapscallion

dangerouslySetInnerHTML fails with arrays

Open

#100 建立於 2017年6月16日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (1,397 star) (68 fork)batch import
enhancementhelp wanted

描述

If you attempt to render a tag such as this:

<p dangerouslySetInnerHTML={{
		__html: content,
}}/>

where content is an array, Rapscallon will fail on the adler checksum generator:

/Users/gcp/Thumbtack/universal-frontend/node_modules/@thumbtack/rapscallion/lib/adler32.js:28
    b += a += data.charCodeAt(i);
                   ^

TypeError: data.charCodeAt is not a function

renderToString() allows for arrays, so it seems like we should handle them here. I can fix by specifying content[0] (all of the arrays I'm dealing with at the moment are 1-length), though I'd need to do some additional research to know exactly what React is expected to output when an array is provided.

貢獻者指南

dangerouslySetInnerHTML fails with arrays · FormidableLabs/rapscallion#100 | Good First Issue