Flagsmith/flagsmith

Race condition in deleting segments

Open

#7,354 建立於 2026年4月27日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Python (3,475 star) (264 fork)batch import
buggood first issue

描述

Acceptance Criterion

  • The asynchronous task delete_segment ignores it when the segment is already deleted.

Sentry Issue: FLAGSMITH-API-5NB

Segment.DoesNotExist: Segment matching query does not exist.
(3 additional frame(s) were not displayed)
...
  File "segments/tasks.py", line 14, in delete_segment
    Segment.objects.get(pk=segment_id).delete()

Failed to execute task 'tasks.delete_segment', with id 410046727. Exception: Segment matching query does not exist.

貢獻者指南

技術棧
python
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Python
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The bug occurs in `segments/tasks.py` at line 14 where `Segment.objects.get(pk=segment id).delete()` is called without checking if the segment exists. The fix is to use a try/except block to catch `Segment.DoesNotExist` and silently ignore it, or to use `get object or 404` and handle the exception. Review the `delete segment` task and implement a check for existence before deletion.