Flagsmith/flagsmith

Permalinks to features do not work if the feature is after the first page

Open

#4,239 建立於 2024年6月25日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Python (3,475 star) (264 fork)batch import
buggood first issue

描述

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

This link points to a feature in a project with more than 50 features, which causes pagination: https://app.flagsmith.com/project/18444/environment/UgLNVEFpLooRAwiwLdY8bR/features?feature=97961&tab=value

Because the target feature is located on the second page, the feature modal does not open and the link just lands you on the first page of features.

Steps To Reproduce

  1. Create over 50 features in a project
  2. Try to open a link to any feature after the first page

Expected behavior

Permalinks to features should work no matter how many features a project has.

Screenshots

No response

貢獻者指南

技術棧
pythonreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
understanding of paginationexperience with React
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The bug occurs because the permalink does not handle cases where the target feature is on a different page. Investigate the frontend code that reads the 'feature' query parameter and opens the modal. Look at how pagination is implemented, likely in the features list component. Ensure that when a feature ID is provided, the correct page is loaded before opening the modal.