Flagsmith/flagsmith

Limit number of environments

Open

#3,875 建立於 2024年5月2日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Python (3,475 star) (264 fork)batch import
good first issue

描述

Since there are some query patterns that are inherently N+1 given the way our permission system works, we should soft limit the number of environments users can create to partially mitigate this impact.

This morning @matthewelwell ran some queries in production and it turns out we have active users that have huge numbers of environments (in the thousands). So whatever limit we put into place will have to grandfather in the existing clients since they're already operating above them.

The suggested limit is to put it at 100 and perhaps we should build in the ability to grant more limits for users that really want them.

貢獻者指南

技術棧
python
領域
backendperformance
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
DjangoSQLPermission system
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the current environment model and permission system in the Flagsmith repository. Identify where N+1 queries occur in environment related views. Design a soft limit that checks the count of environments per user/organization before creation. Consider adding a migration to record existing environment counts for grandfathering. The limit configuration could be added to organization settings or a new model.
Limit number of environments · Flagsmith/flagsmith#3875 | Good First Issue