Famous/engine

GestureHandler doesn't fire "tap" for IE<11

Open

#323 建立於 2015年6月22日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (1,750 star) (262 fork)batch import
bughelp wanted

描述

GestureHandler doesn't work for IE 10 and below. In famous-carousel, I've worked around it by calling this directly on the DOM element when IE is detected:

arrowEl.attachEvent("onclick", emitPageChange);

MS docs say addEventListener should work for IE 9+, but this doesn't seem to be the case. I could only get it to recognize clicks by calling attachEvent.

I loathe IE as much as anyone, but there are still a lot of systems running IE 9 & 10 and Famo.us does run on them for the most part. I looked through the engine code and from what I can tell, DOMElement.prototype.on() might be the place to modify. Would something like this be better placed under polyfills, if the Famo.us team finds it acceptable?

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with JavaScript DOM eventsUnderstanding of browser compatibilityKnowledge of polyfills
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the DOMElement.prototype.on method in Famous Engine's codebase. The user suggests adding an attachEvent fallback for IE<11. Review existing polyfills in the project to determine if a similar approach is used elsewhere. The issue mentions that addEventListener doesn't work for IE9/10, so testing with those browsers is necessary. Check comments on the issue for any additional insights or prior attempts.