Eugeny/tabby

Add an option to disable automatic text selection when right clicking on macOS

Open

#9,237 建立於 2023年11月15日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)TypeScript (71,314 star) (4,018 fork)batch import
Good first issueOS: macOST: Enhancement

描述

Version: 1.0.204 Platform: macOS x64 14.1.1 Plugins: none Frontend: xterm-webgl

I'm running tabby 1.0.204 on MacBook Pro (MacOS 14.1.1) and the 'Right click' in 'Mouse' settings is set to 'Paste'. When I mark a text string and right-click mouse button without moving mouse pointer, the text will be pasted at the cursor position as expected. If I moved the mouse pointer to another text string, then right-click will actually copy the text where mouse pointer points to and paste it at the cursor position instead of the text marked previously.

This behavior doesn't happen on Windows 10/11 (same Tabby version) and I think it is not correct since 'Right click' of 'Mouse' is set to 'Paste', not anything else. By the way, this also happens in previous Tabby versions for MacOS.

Thanks.

tabby 00 tabby 01 tabby 02

貢獻者指南

技術棧
typescriptelectron
領域
desktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ElectronmacOS event handlingxterm.js
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Investigate the right click behavior in Tabby on macOS by examining the xterm.js mouse event handling in xterm addon webgl. The issue likely stems from macOS specific right click behavior that triggers text selection. Check the event propagation in the Electron webview or xterm's 'selection' event. Consider adding an option to disable automatic text selection on right click.