Esri/arcgis-rest-js

`isItemSharedWithGroup` returns `undefined` instead of false.

開放

#665 建立於 2020年3月3日

 (2 則留言) (0 個反應) (0 位負責人)TypeScript (126 個分叉)auto 404
good first issuehelp wanted

倉庫指標

星標
 (389 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

The return statement in isItemSharedWithGroup is incorrectly nested in an if block. This one flies under the radar because undefined is falsy, but it's a bug nonetheless.

function isItemSharedWithGroup(requestOptions) {
  var searchOpts = {
    q: "id: " + requestOptions.id + " AND group: " + requestOptions.groupId,
    start: 1,
    num: 10,
    sortField: "title",
    authentication: requestOptions.authentication,
    httpMethod: "POST"
  };
  return Object(_items_search__WEBPACK_IMPORTED_MODULE_7__["searchItems"])(searchOpts).then(function (searchResponse) {
    var result = false;

    if (searchResponse.total > 0) {
      result = searchResponse.results.some(function (itm) {
        return itm.id === requestOptions.id;
      });
      return result; // SHOULD BE OUTSIDE THE IF BLOCK
    }
  });
}

貢獻者指南