EasyEngine/easyengine

Remove site specific global flags

Open

#1,212 建立於 2018年9月10日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)PHP (429 fork)batch import
good first issue

倉庫指標

Star
 (1,984 star)
PR 合併指標
 (平均合併 20天 14小時) (30 天內合併 7 個 PR)

描述

php/config-spec.php defines flags that can be passed to any command i.e. --debug.

However it contains following flags which are site specific which needs to be removed - sites_path,locale(for wordpress), le-mail.

One advantage of adding these flags is that it automatically searches from config file for these variables and gets their values. However, since we've moved every site specific thing from core to their packages, it makes no sense to keep package specific flags here.

Also wherever these flags are used in other commands, we need to add local flags(to command) and also ensure that these values are read from config file so that earlier behaviour is preserved.

貢獻者指南