Doichain/dapp

Security: RPC-API-CALL sendrawtransaction needs validation

開放

#116 建立於 2019年10月29日

 (1 則留言) (0 個反應) (0 位負責人)JavaScript (13 個分叉)auto 404
A prioritybountyenhancementgood first issuehelp wantedsecurity

倉庫指標

星標
 (6 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

When calling RPC-API sendrawtransaction please validate and limit the data given over the body parameters to prevent dDoS attacks.

This RPC-Call is located in: meteor-api package: https://github.com/Doichain/meteor-api inside file: server/api/rest/imports/send.js around line 639: Api.addRoute(DOICHAIN_BROADCAST_TX, { parameter*: !params.templateDataEncrypted || ... etc. is not yet limited. The size of this parameter (size of data) should be able to be limited in settings

The question here is if restivus (the REST API package of meteor) already has such capabilities or we must do it AFTER we received 1 GB of data. I think this could be already too late here.

貢獻者指南