WeakEventListener in NetworkConnectionStateTrigger is duplicated · CommunityToolkit/WindowsCommunityToolkit#4059 | Good First Issue

(1 留言) (0 反應) (1 負責人)C# (1,403 fork)batch import

Hacktoberfestbug :bug:good first issuehelp wantedimprovements :sparkles:

倉庫指標

Star: (5,708 star)
PR 合併指標: (30 天內沒有已合併 PR)

描述

Describe the bug

Looks like NetworkConnectionStateTrigger is using a private copy of WeakEventListener, it's identical to the one we already have in the Toolkit, so we should update the source to use the existing code within the Toolkit.

https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/ebb12e0c38c22ec01849e202f8e477d8c1a67061/Microsoft.Toolkit.Uwp.UI/Triggers/NetworkConnectionStateTrigger.cs#L73

Expected behavior

Use existing code over shadow copy.

https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/ebb12e0c38c22ec01849e202f8e477d8c1a67061/Microsoft.Toolkit.Uwp/Helpers/WeakEventListener.cs#L17

貢獻者指南

研究方向: 該問題識別出 NetworkConnectionStateTrigger.cs（路徑：Microsoft.Toolkit.Uwp.UI/Triggers/NetworkConnectionStateTrigger.cs）中存在重複的 WeakEventListener。修復方法涉及移除該私有副本，並將其使用替換為 Microsoft.Toolkit.Uwp/Helpers/WeakEventListener.cs 中現有的 WeakEventListener。請檢查第 73 行處的重複類別，然後更新 using 指令和參考以指向共用的協助程式。確保沒有破壞性變更，並且命名空間已正確匯入。
技術棧: csharp
領域: frontend
議題類型: 重構
難度: 1
預計時間: 1 小時以內
活動狀態: 活躍
清晰度: 清晰
前置要求: C#Git
新手友善度: 85