CleverRaven/Cataclysm-DDA

attempting to craft something that "in progress" is over 1000L deletes the item

Open

#62,258 建立於 2022年11月17日

在 GitHub 查看
 (3 留言) (1 反應) (0 負責人)C++ (3,991 fork)batch import
(P3 - Medium)(S2 - Confirmed)Help Wanted[C++]

倉庫指標

Star
 (9,264 star)
PR 合併指標
 (平均合併 6天 5小時) (30 天內合併 292 個 PR)

描述

Describe the bug

when you try to craft something that results in the "in progress " pseudo item volume exceeding the max volume of the crafting spot, the game throws an error and deletes the "in progress " pseudo item.

Steps to reproduce

  • set up a crafting spot with only 1000L of volume (ex fiber mat)
  • using the recipe that crafts heavy wooden beams using 6 logs and a tree cutting tool of 2. batch craft this recipe at least with the 4 times multiple.
  • observe the game throwing an error and deleting the items you were trying to craft.

Expected behavior

the game failing this issue in some way that does not result in player loosing items.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19044.2130 (21H2)
  • Game Version: 26a4725 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], No Fungal Growth [no_fungal_growth], Bionic Professions [package_bionic_professions], Xedra Evolved [xedra_evolved], No Hope [no_hope], Blaze Industries [blazeindustries], Aftershock [aftershock], Tamable Wildlife [Tamable_Wildlife], Stats Through Skills [StatsThroughSkills], Bionic Slots [cbm_slots], SpeedyDex [speedydex] ]

Additional context

  • the in progress recipe mentioned in the steps to reproduce are for some reason 300L per heavy wooden beam

  • the easiest fix I can think of is to cap the volume of in process pseudo items to 1000L

貢獻者指南