Chocobozzz/PeerTube

Support disabling rates limit

Open

#6,089 建立於 2023年12月6日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)TypeScript (11,911 star) (1,362 fork)batch import
Type: Feature Request :sparkles:good first issue

描述

Describe the problem

This is my current rate limits configure

rates_limit:
  api:
    window: 10 seconds
    max: 0
  login:
    window: 5 minutes
    max: 0
  signup:
    window: 5 minutes
    max: 0
  ask_send_email:
    window: 5 minutes
    max: 0
  receive_client_log:
    window: 10 minutes
    max: 0
  plugins:
    window: 10 seconds
    max: 0
  well_known:
    window: 10 seconds
    max: 0
  feeds:
    window: 10 seconds
    max: 0
  activity_pub:
    window: 10 seconds
    max: 0
  client:
    window: 10 seconds
    max: 0

When I visit the page, I received 429 Too many request error.

If I want to set all peertube rate limits to unlimit in v6.0.1, what value should I set?

Additional information

  • PeerTube instance URL:
  • PeerTube version: v6.0.1
  • NodeJS version: v18.19.0
  • Ffmpeg version:
  • Redis version: 7.0
  • PostgreSQL version: 13.3

貢獻者指南

技術棧
typescriptnodejsredispostgresql
領域
backend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
needs maintainer response
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
needs investigation
前置要求
basic YAML understandingPeerTube admin experience
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the rate limiting configuration parsing and middleware implementation in PeerTube. The issue suggests that setting max to 0 should disable rate limiting but results in a 429 error. Determine if the code correctly handles max=0 as unlimited or if there is a bug. Check the documentation for rate limiting and propose either a fix to allow max=0 to disable or a clearer configuration option like 'enabled: false'. Look at files related to rate limiting middleware and configuration validation.