CesiumGS/cesium

Update zip.js dependency to latest

Open

#8,092 建立於 2019年8月20日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)JavaScript (11,758 star) (3,324 fork)batch import
good first issuetype - enhancement

描述

Per the zip.js devs, Cesium is using an older build and it results in instantiating a new web worker for every file added to a ZIP (!!!), greatly slowing the process. This only showed up recently because the KML exporter is probably the first part of Cesium that needs to make ZIP files.

貢獻者指南

技術棧
javascript
領域
performance
議題類型
performance
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with npm or yarnUnderstanding of dependency updatesBasic knowledge of Cesium's build process
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
Investigate the current zip.js version used in Cesium by searching package.json or equivalent files. Refer to zip.js issue #139 (https://github.com/gildas lormeau/zip.js/issues/139) for the recommended version that fixes the excessive worker instantiation. Update the dependency version in the appropriate configuration file and verify that the KML exporter works correctly without performance degradation.