Automattic/monk

Manager._state not updated after reconnect

Open

#293 建立於 2020年2月7日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (1,847 star) (202 fork)batch import
bughelp wanted

描述

When following events are emitted:

  • open
  • close
  • reconnect The connection _state parameter is still STATE.CLOSED from the close event.

This because when a reconnect event is emitted by the MongoClient, the Manager _state parameter isn't updated to STATE.OPEN.

貢獻者指南

技術棧
javascriptnodejsmongodb
領域
backenddatabase
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Node.js basicsevent handlingMonk library structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Investigate Manager.js file, specifically the event listeners for 'open', 'close', and 'reconnect'. The issue states that after 'close' sets state to STATE.CLOSED, the subsequent 'reconnect' event does not update it back to STATE.OPEN. Look at how the reconnect handler is implemented and ensure it sets state appropriately. Check for any comments or linked PRs; none exist. The fix likely involves adding a state update in the reconnect listener.