Bug: Disable archive method selection in UI if method is disabled via config or not installed · ArchiveBox/ArchiveBox#881

(2 留言) (2 反應) (0 負責人)Python (19,591 star) (1,069 fork)batch import

expected: maybe somedayhelp wantedsize: mediumstatus: idea-phasetouches: API/CLI/Spectouches: configurationwhy: functionality

描述

Describe the bug

I've disabled most archive methods (e.g. SAVE_MERCURY=False), but when adding a new link to the archive the archive method selection field still shows the disabled methods. You can select them, but of course they just do not work.

Actually I'd expect, that disabled methods do not appear in this list.

Screenshots or log output

archive-methods

ArchiveBox version

ArchiveBox v0.6.2
Cpython Linux Linux-5.13.19_1-x86_64-with-glibc2.28 x86_64
IN_DOCKER=True DEBUG=False IS_TTY=True TZ=UTC SEARCH_BACKEND_ENGINE=ripgrep

[i] Dependency versions:
 √  ARCHIVEBOX_BINARY     v0.6.2          valid     /usr/local/bin/archivebox                                                   
 √  PYTHON_BINARY         v3.9.5          valid     /usr/local/bin/python3.9                                                    
 √  DJANGO_BINARY         v3.1.10         valid     /usr/local/lib/python3.9/site-packages/django/bin/django-admin.py           
 √  CURL_BINARY           v7.64.0         valid     /usr/bin/curl                                                               
 -  WGET_BINARY           -               disabled  /usr/bin/wget                                                               
 √  NODE_BINARY           v15.14.0        valid     /usr/bin/node                                                               
 √  SINGLEFILE_BINARY     v0.3.16         valid     /node/node_modules/single-file/cli/single-file                              
 -  READABILITY_BINARY    -               disabled  /node/node_modules/readability-extractor/readability-extractor              
 -  MERCURY_BINARY        -               disabled  /node/node_modules/@postlight/mercury-parser/cli.js                         
 -  GIT_BINARY            -               disabled  /usr/bin/git                                                                
 -  YOUTUBEDL_BINARY      -               disabled  /usr/local/bin/youtube-dl                                                   
 √  CHROME_BINARY         v90.0.4430.93   valid     /usr/bin/chromium                                                           
 √  RIPGREP_BINARY        v0.10.0         valid     /usr/bin/rg                                                                 

[i] Source-code locations:
 √  PACKAGE_DIR           22 files        valid     /app/archivebox                                                             
 √  TEMPLATES_DIR         3 files         valid     /app/archivebox/templates                                                   
 -  CUSTOM_TEMPLATES_DIR  -               disabled                                                                              

[i] Secrets locations:
 -  CHROME_USER_DATA_DIR  -               disabled                                                                              
 -  COOKIES_FILE          -               disabled                                                                              

[i] Data locations:
 √  OUTPUT_DIR            5 files         valid     /data                                                                       
 √  SOURCES_DIR           9 files         valid     ./sources                                                                   
 √  LOGS_DIR              1 files         valid     ./logs                                                                      
 √  ARCHIVE_DIR           6 files         valid     ./archive                                                                   
 √  CONFIG_FILE           283.0 Bytes     valid     ./ArchiveBox.conf                                                           
 √  SQL_INDEX             236.0 KB        valid     ./index.sqlite3

貢獻者指南

技術棧: pythondjangojavascript
領域: frontend
議題類型: bug
難度: 2
預計時間: 1-3 hours
活動狀態: stale
清晰度: clear
前置要求: Python basicsDjango template syntax
新手友善度: 60
研究方向: Examine the template for the 'add new link' page (likely in archivebox/templates/) to find the dropdown for archive methods. The methods are probably passed to the template from the view. Check how config flags like SAVE MERCURY are loaded (likely from config model or environment). Filter out disabled methods in the view before rendering, or conditionally hide them in the template. The config is read at startup; you may need to pass a list of enabled methods to the template context.