AbsaOSS/enceladus

Refactor Validation Utils

開放

#57 建立於 2018年12月2日

 (1 則留言) (0 個反應) (0 位負責人)Scala (16 個分叉)auto 404
Conformancegood first issuepriority: undecidedrefactoring

倉庫指標

星標
 (33 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

We have two separate ValidationExceptions:

  • za.co.absa.enceladus.conformance.interpreter.rules.ValidationException (only used in Standardization)
  • za.co.absa.enceladus.utils.validation.ValidationException (only used in Conformance) Conformance also dips into za.co.absa.enceladus.utils.validation.ValidationUtils before throwing its own ValidationException, which blurs the line between which ValidationException is responsible for what.

Good design dictates a clear separation between the two or a unification.

There is also some code duplication in conformance rules, specifically aimed at validation, that would best be extracted to a common location.

貢獻者指南