89luca89/terrible

[IMPROVEMENT] Improve Asserts

開放

#87 建立於 2021年7月4日

 (3 則留言) (0 個反應) (1 位負責人)YAML (29 個分叉)github user discovery
bugenhancementexperimentalhelp wanted

倉庫指標

星標
 (257 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

Some assertions should be improved, for example:

            host-vm-1:
              disk_source: "/mnt/iso/debian10-terraform.qcow2"
              os_family: Debian
              cpu: 1
              memory: 512
              hypervisor: hypervisor_1
              ansible_host: 192.168.122.9
              network_interfaces:
                iface_1:
                  name: default
                  type: nat
                  ip: 192.168.122.9
                  gw: 192.168.122.1
                  dns:
                    - 192.168.122.1
              default_route: True <<<--- note this is unindented

This snippets passes the assertions even if it's not valid We should review and evaluate more corner cases to include in the assertions

Also we could think of an external tool/linter as @alegrey91 suggests to validate inventories

貢獻者指南