Improve organization of various helpers once miden-crypto is merged into the repo
#3,415 建立於 2026年7月22日
倉庫指標
- 星標
- (753 顆星)
- PR 合併指標
- (平均合併 6天 2小時) (30 天內合併 71 個 PR)
描述
This crate doesn't depend on
miden-core, onlymiden-serde-utils, and we don't want it to depend onmiden-core(I suspect it can't in any case, due to cyclic dependencies). I'm not sure why these helpers were added tomiden-corerather thanmiden-serde-utils(probably because it would've been too much of a pain to do the release cycle dance), but these can be removed in favor of ones inmiden-serde-utilsonce we can move them frommiden-coretomiden-serde-utilsand havemiden-corejust re-export them.For now this was the only way to get those helpers where they were needed.
Originally posted by @bitwalker in https://github.com/0xMiden/miden-vm/pull/3398#discussion_r3626097131
Now that the miden-crypto repo is being integrated into the miden-vm repo, we can migrate some helpers around to avoid some unnecessary duplication that was introduced just to avoid the dependency management pain:
-
miden-coredefines some useful serialization helpers under itsserdenamespace that should be moved tomiden-serde-utils - This will allow duplicate copies of those helpers in
miden-utils-indexingto be removed in favor of the ones inmiden-serde-utils(as it does not/cannot depend onmiden-core)
There may be other similar duplication that we should document/tackle as part of this issue. I could not land the two above on main because the merge hasn't happened there yet, so these changes will need to be implemented against next