0xMiden/examples

Benchmarking CLI improvements

開放

#39 建立於 2022年12月21日

 (2 則留言) (0 個反應) (1 位負責人)TypeScript (25 個分叉)github user discovery
good first issue

倉庫指標

星標
 (21 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

A few small things that would be great to improve in benchmarking CLI:

  1. We should use structop instead of clap as thats what we use for all other CLIs (e.g., here).
  2. We should keep CLI parameters as consistent as possible across different CLIs (e.g., for how we specify security, number of outputs etc.). See example here.
  3. Let's change the executable file name to something like miden-bench (miden-benchmarking-cli is way too long).
  4. miden::prove() also includes execution time, I believe. So, to make things more clear, we should probably label it as "Execution + proving time" or something like that.
  5. Would also be great to print out proof size.

貢獻者指南