zenoamaro/react-quill

False positive "You are passing the delta object from the onChange event back as value"

Open

#498 opened on Jul 8, 2019

View on GitHub
 (6 comments) (7 reactions) (0 assignees)JavaScript (6,238 stars) (860 forks)batch import
good first issuehelp wanted

Description

In my case, when both nextContents and this.lastDeltaChangeSet are undefined, I get this error. It happens in a real scenario when I switch between 2 records, and component.js componentWillReceiveProps gets called

From component.js:

if (nextContents === this.lastDeltaChangeSet) {
        console.error(nextContents, this.lastDeltaChangeSet)
        throw new Error(
          'You are passing the `delta` object from the `onChange` event back ' +
            'as `value`. You most probably want `editor.getContents()` instead. ' +
            'See: https://github.com/zenoamaro/react-quill#using-deltas'
        )
      }

React-Quill version

1.3.3

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
React component lifecycleQuill delta understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue is in component.js, where a check throws an error when both nextContents and this.lastDeltaChangeSet are undefined. The condition should handle the case where both are undefined (e.g., first render with no value). Look at the React component's componentWillReceiveProps method and the delta comparison logic. Consider adding a guard clause returning early when both are undefined to avoid the false positive.