zen-browser/desktop

"Pin Tab" missing in keyboard shortcut settings

Open

#4504 opened on Jan 21, 2025

View on GitHub
 (2 comments) (5 reactions) (0 assignees)JavaScript (42,031 stars) (1,498 forks)batch import
Buggood first issueplatform: linuxplatform: macOSplatform: windows

Description

Captchas

  • I have read the instructions.
  • I have searched existing issues and avoided creating duplicates.
  • I am not filing an enhancement request.

What happened?

I have set it up to CMD+E sometime ago and it worked fine. Today I noticed it doesn't work, so I wanted to make sure it is set up correctly and it looks like it disappeared from the settings (or at least the label).

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.7.1b

What platform are you seeing the problem on?

macOS - aarch64

Relevant log output if applicable

Contributor guide

Tech stack
javascriptelectron
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic understanding of Electron appsfamiliarity with settings UI code
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the settings UI component responsible for keyboard shortcuts. Look for recent commits that may have affected the 'Pin Tab' shortcut entry. The issue suggests a regression, so comparing the current behavior with the version where it worked (1.7.1b) could help. The settings panel is likely in the zen browser/desktop repository under a 'settings' or 'preferences' directory. Check if the shortcut is defined in a configuration file or hardcoded.