zalmoxisus/redux-devtools-extension

Sets aren't properly diffed or displayed

Open

#452 opened on Jan 30, 2018

View on GitHub
 (1 comment) (8 reactions) (0 assignees)JavaScript (1,074 forks)batch import
help wantedmonitor

Repository metrics

Stars
 (13,478 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Just wanted to make you aware of a possible bug. When passing a new set as a key of the initial state:

{
  items: new Set()
}

and then later adding to the set like so:

const newItems = new Set(state.items)
newItems.add("newItem")
return {...state, items: newItems}

the redux devtools evaluates the diff as no change, while logging the state shows that an item was added.

Let me know if you want any more details about this bug. I have a workaround that I'm using to log the items when needed, but thought you might want to know.

Contributor guide

Research direction
Inspect the redux devtools extension serialization and diff logic for Set objects. Look for how the extension handles non plain objects in state, and consider adding support for Set serialization or improving diff calculation.
Tech stack
javascript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptRedux
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70