maintain state on navigation pop
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- ios, swift
- Domain
- mobile-dev
Research direction
Start by reproducing the tab-selection and navigation-pop sequence in SwipeMenuViewController using the UIKit navigation flow described in the issue. Inspect how the selected tab, table scroll position, and setup callbacks behave when returning from a pushed controller. Done means the third tab and its previous scroll position are preserved after pop, without duplicate setup callbacks.
Written by the indexing model from the issue text.
Description
Describe the bug
Hi,
I'm using this module as SwipeMenuView, because my controller already extends a my base controller.
For each tab I'm using another my controller that extends UITableViewController; each cells of these tables push to another controller programmatically.
I noticed this issue:
- Go to controller with SwipeMenuView
- Swipe to third tab
- Click on a 30th cell and go to another controller
- Click on back button in navigation bar
- I return in controller with SwipeMenuView with first tab selected [BUG]
Expected result: return in controller with SwipeMenuView with third tab selected and table view scrolled to previous position
consider that:
- swipeMenuView.reloadData is not called on pop because I implemented a mecanism for avoid some action on back
- I noticed that when I left (on push) my swipe menu controller SwipeMenuView willsetup and SwipeMenuView didsetup are called. When I return (on pop) in my swipe menu controller SwipeMenuView willsetup and SwipeMenuView didsetup are called two time for each. Why?
thanks
- Dominant language
- Swift
- Stars
- 1.3k
- Forks
- 128
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from yysskk/SwipeMenuViewController
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
-
set padding have bug Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
yysskk/SwipeMenuViewController#111 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
All issues in yysskk/SwipeMenuViewController
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
type: docs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
googleapis/google-cloud-swift#971 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
bitcoindevkit/bdk-ffi#1125 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
mozilla-mobile/firefox-ios#35743 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
manaflow-ai/cmux#13417 ·