yugabyte/yugabyte-db

[platform] Enhance metrics that use sum without to also exclude namespace_name

Open

#9,759 opened on Aug 17, 2021

View on GitHub
 (0 comments) (0 reactions) (2 assignees)C (1,003 forks)batch import
area/platformgood first issue

Repository metrics

Stars
 (8,229 stars)
PR merge metrics
 (Avg merge 17d 21h) (92 merged PRs in 30d)

Description

We have a problem with Platform metrics, related to all the aggregations where we normally exclude tables (ie: sum without (table_id, table_name)), due to now also adding namespace_name into the Prometheus KV labels see https://yugabyte.slack.com/archives/C01HD5HPK8A/p1629237388110200?thread_ts=1628874648.049900&cid=C01HD5HPK8A for context

TL;DR: we probably need to augment all metrics.yml entries which use sum without, to also exclude namespace_name I think the source of this is this diff from a long time back: https://phabricator.dev.yugabyte.com/D9182

Contributor guide

Research direction
Find all metrics.yml files in the codebase that contain 'sum without' and add 'namespace name' to the exclusion list.
Tech stack
None
Domain
backenddatabaseobservability
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPrometheus
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70