yugabyte/yugabyte-db

Flush/Compact requests from master -> tserver should have its own deadline/num_retries

Open

#9,168 opened on Jul 1, 2021

View on GitHub
 (2 comments) (0 reactions) (1 assignee)C (1,003 forks)batch import
good first issue

Repository metrics

Stars
 (8,229 stars)
PR merge metrics
 (Avg merge 17d 21h) (92 merged PRs in 30d)

Description

Flush/Compact requests to the tServer are rpcs that are expected to take a long time. It does not make sense for these to use the same deadline (20s) and num_retries as other async_rpc_tasks.

We should have these tasks override these settings; similar to what BackfillChunk does to give itself more time; and also to disble/reduce retries in the case of flush/compact.

Without having this, we are forced to use yb-admin to set set_flag unresponsive_ts_rpc_retry_limit 0 each time we want to issue a flush/compact request.

Contributor guide

Research direction
Examine how BackfillChunk overrides default deadline and num retries. Then apply similar custom settings to flush/compact RPC tasks from master to tserver, possibly by introducing new flags or configuration parameters.
Tech stack
ccpp
Domain
databasedistributed systems
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55