yugabyte/yugabyte-db

Gflags that require port number in their arguments should assume defaults if not passed

Open

#837 opened on Feb 5, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C (1,003 forks)batch import
help wantedkind/enhancement

Repository metrics

Stars
 (8,229 stars)
PR merge metrics
 (Avg merge 17d 21h) (92 merged PRs in 30d)

Description

When you pass GFLAG parameters that require port numbers such as --rpc_bind_addresses, --server_broadcast_addresses, tserver_master_addrs, et al, if the address only is passed without the corresponding port number it would be nice if we assumed the default port for that particular argument / parameter. There should also be a sanity check to make sure that if the port number is passed that it doesn't conflict with another known YB port (e.g. rpc vs webserver ports).

Contributor guide

Research direction
Look at how gflags are defined in the YB codebase, particularly for port related arguments like rpc bind addresses. Implement default port logic when port is omitted and add validation to prevent port conflicts.
Tech stack
c
Domain
backenddatabase
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C programmingGflags
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65