yugabyte/yugabyte-db

[docdb] master UI hash_split of last partition should be inclusive

Closed

#6,299 opened on Nov 6, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C (1,003 forks)batch import
area/docdbgood first issuehelp wantedkind/bugpriority/medium

Repository metrics

Stars
 (8,229 stars)
PR merge metrics
 (Avg merge 17d 21h) (92 merged PRs in 30d)

Description

Jira Link: DB-4659 The master UI table page has tablets with their partition boundaries. Recent commit dca4cf4ef52d768ea955ffe9a1b0b7ceffd20a9c made the format of the boundaries into hex notation. It also converted the "start" and "end" words to 0x0000 and 0xffff, respectively.

Now, it's a lot more obvious that there's an issue with all the boundaries being [foo, bar), foo being inclusive and bar being exclusive. Before, it looked like [foo, <end>), which is sort of fine depending on your interpretation of "end"; now, it looks like [foo, 0xffff), which is definitely incorrect. Change that last partition to be all inclusive so that it looks like [foo, 0xffff]. As of now, this is only applicable to YCQL hash partitioned tables.

Contributor guide

Research direction
Look at the file responsible for rendering partition boundaries in the master UI. The commit dca4cf4ef52 changed the format to hex notation; find the code that outputs the boundary string and change the last partition's end bracket from ')' to ']' to make it inclusive. Also check if the same issue exists for other table types.
Tech stack
ccpp
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
basic C++ knowledgeunderstanding of hash partitioning
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80