yugabyte/yugabyte-db

[docdb] Better log rotation

Open

#3,604 opened on Feb 10, 2020

View on GitHub
 (6 comments) (1 reaction) (0 assignees)C (1,003 forks)batch import
area/docdbgood first issuehelp wantedkind/enhancementpriority/medium

Repository metrics

Stars
 (8,229 stars)
PR merge metrics
 (Avg merge 17d 21h) (92 merged PRs in 30d)

Description

Jira Link: DB-2438 Hi

We need a better log rotation policy. 1 way is to keep static naming and allow another process to rotate: https://github.com/google/glog/pull/19 (patch https://github.com/google/glog/commit/58d7f873dcde8cf0fe6f37817643a7ff4e49e6d4)

Another way would be to add an option glog_delete_after and a simple bg thread to enforce the policy. For now, having glog_delete_after=<size> should be a good start. It will take us a day or two to implement and probably save us devops trouble in different environments (k8s sidecar comes to mind).

Contributor guide

Research direction
Research the Google glog library for log rotation patterns and evaluate the referenced patch. Understand the current logging mechanism in YugabyteDB's docdb component and design a thread safe file size based deletion policy.
Tech stack
ccpp
Domain
backenddatabaseinfrastructure
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C/C++Logging conceptsGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40