yugabyte/yugabyte-db

[DocDB] Only allow one RBS session per tablet/peer combo

Open

#26,144 opened on Feb 21, 2025

View on GitHub
 (0 comments) (0 reactions) (1 assignee)C (1,003 forks)batch import
area/docdbgood first issuekind/enhancementpriority/medium

Repository metrics

Stars
 (8,229 stars)
PR merge metrics
 (Avg merge 17d 21h) (92 merged PRs in 30d)

Description

Jira Link: DB-15477

Description

https://phorge.dev.yugabyte.com/diffusion/YBDB/browse/master/src/yb/tserver/remote_bootstrap_service.cc$394

  MonoTime now = MonoTime::Now();
  const string session_id = Substitute("$0-$1-$2", requestor_uuid, tablet_id, now.ToString());

allows for multiple RBS sessions for the same follower. This should be unnecessary and can lead to ooms if left uncontrolled.

We should only allow at most 1 pending RBS session for a follower, and end previous sessions when a new session is created.

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.

Contributor guide

Research direction
Investigate the RBS session management in remote bootstrap service.cc. Modify the session creation logic to check for existing sessions for the same tablet/peer combination before starting a new one. If a session exists, end the previous session before creating the new one. Ensure thread safety and cleanup of stale sessions.
Tech stack
cpp
Domain
backenddatabasedistributed systems
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Distributed systemsYugabyteDB internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30