yugabyte/yugabyte-db

[DocDB] IntentAwareIterator::Next() does not advance intent iterator

Open

#22,605 opened on May 29, 2024

View on GitHub
 (0 comments) (0 reactions) (1 assignee)C (1,003 forks)batch import
area/docdbgood first issuekind/bugpriority/low

Repository metrics

Stars
 (8,229 stars)
PR merge metrics
 (Avg merge 17d 21h) (92 merged PRs in 30d)

Description

Jira Link: DB-11515

Description

Current implementation of the method:

void IntentAwareIterator::Next() {
  VLOG_WITH_FUNC(4);

  if (!status_.ok()) {
    return;
  }

  if (IsEntryRegular()) {
    SkipFutureRecords<Direction::kForward>(iter_.Next());
    FillEntry();
  }
}

There is no logic for the intent_iter_, which seems wrong as it should be moved next in some cases.

Currently, the method is used only from GetHelperBase::Prepare() for the row getter initialization. And it does not lead to any inconsistency, but gives an extra decoding (i.e. for a packed record or delete record) and maybe one extra Seek/Next call.

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.

Contributor guide

Research direction
Examine the IntentAwareIterator::Next() method and understand when intent iter should be advanced. Trace the usage in GetHelperBase::Prepare() to confirm the current behavior and identify the missing logic.
Tech stack
ccpp
Domain
databasebackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Database internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50