yugabyte/yugabyte-db

[YSQL] Update `IndexAMProperty` API to be in sync with YB additions to `IndexAmRoutine`

Open

#22,246 opened on May 3, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C (1,003 forks)batch import
area/ysqlgood first issuekind/enhancementpriority/mediumstatus/awaiting-triage

Repository metrics

Stars
 (8,229 stars)
PR merge metrics
 (Avg merge 17d 21h) (92 merged PRs in 30d)

Description

Jira Link: DB-11164

Description

We have added a few interface methods to IndexAMRoutine in access/amapi.h. However, this comment says that property additions to this struct must alos be reflected in the "property API". This would allow the PG functions pg_indexam_has_property, pg_index_has_property and pg_index_column_has_property to access these new properties.

This issue tracks this sync-up that needs to be done between the two structures as the linked comment suggests.

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.

Contributor guide

Research direction
Examine the comment at line 243 in src/postgres/src/include/access/amapi.h to understand the required property additions, then update the IndexAMProperty related functions in the same file to include the new properties introduced in IndexAmRoutine.
Tech stack
cpostgresql
Domain
backenddatabase
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CPostgreSQL index access method internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40