yugabyte/yugabyte-db

[DocDB] Add metrics around MemTracker::GcTcmalloc

Open

#17,375 opened on May 16, 2023

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C (1,003 forks)batch import
area/docdbgood first issuekind/enhancementpriority/medium

Repository metrics

Stars
 (8,229 stars)
PR merge metrics
 (Avg merge 17d 21h) (92 merged PRs in 30d)

Description

Jira Link: DB-6564

Description

We should add some metrics around how many times we call it and how much memory we release at a time. This is primarily useful for the tserver, but could also be valuable for PG, as we now use a MemTracker in PG and we've observed, in some benchmarks, that the PG time spent on the MemTracker can add up to 5% total time to the scan queries. cc @spolitov @timothy-e

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.

Contributor guide

Research direction
Examine MemTracker::GcTcmalloc implementation and existing metrics infrastructure to add counters for call frequency and memory released per call.
Tech stack
cpp
Domain
backenddatabase
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Memory managementMetrics systems
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40